Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Selection variables don't support negative values

#73

If the "values" parameter of a selection variable includes negative numbers, they get turned into positive numbers. This happens because the values are split up with boost::tokenizer<>, which uses the default (and deprecated) char_delimiters_separator, which seems to treat all punctuation characters as delimiters.

The fix is to use char_separator and explicitly specify the delimiter characters. This leads to the question: Which delimiters should we support? Commas only? Commas and spaces?

Reported by Christopher Stawarz · April 25th, 2011 @ 11:46 AM

State: resolved
Milestone: 0.5.0
Assigned to: Christopher Stawarz Christopher Stawarz

Activity

  1. Christopher Stawarz
  2. Christopher Stawarz
    Christopher Stawarz

    Which delimiters should we support? Commas only? Commas and spaces?

    I haven't seen any examples of folks using non-comma separators, so I think supporting commas only should be fine.

    March 1st, 2012 @ 12:37 PM

  3. Christopher Stawarz
    Christopher Stawarz
    • State changed from open to pending

    Fixed on a branch. Will mark as resolved once it's merged to master.

    March 7th, 2012 @ 03:28 PM

  4. Christopher Stawarz
    Christopher Stawarz
    • Milestone set to 0.5.0
    • Milestone order changed from 168166 to 0

    June 13th, 2012 @ 02:14 PM

  5. Christopher Stawarz
    Christopher Stawarz
    • State changed from pending to resolved
    • Assigned user set to Christopher Stawarz
    • Milestone order changed from 7 to 0

    Merged to master

    October 3rd, 2012 @ 04:13 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.